Closes #309: account for helix group rotation properly in oxdnaoxview export #310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issue #309: account for helix group rotation properly in oxdna/oxview export
Incorrect rotation was caused by adding the helix position within its group to the helix group's position to determine helix position.
The helix's local position within its group must be rotated according to yaw, roll, and pitch of the group itself before being added to the group's position.
Additionally, the use of
design.roll_of_helix(helix)
instead of using theroll
attribute of the helix group when calculating the oxDNA vectors necessary for export, is not the right thing to do in this function.design.roll_of_helix(helix)
adds the helix's local roll to the global roll of the helix groupThese don't line up unless the helix is at the origin of its helix group
It's not entirely clear that the
roll_of_helix
function of aDesign
even has a valid use-caseAfter the changes, the design is exported properly
Related Issue
Issue #309