Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #309: account for helix group rotation properly in oxdnaoxview export #310

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

DanielHader
Copy link
Collaborator

Fixed Issue #309: account for helix group rotation properly in oxdna/oxview export

Incorrect rotation was caused by adding the helix position within its group to the helix group's position to determine helix position.

The helix's local position within its group must be rotated according to yaw, roll, and pitch of the group itself before being added to the group's position.

Additionally, the use of design.roll_of_helix(helix) instead of using the roll attribute of the helix group when calculating the oxDNA vectors necessary for export, is not the right thing to do in this function.

design.roll_of_helix(helix) adds the helix's local roll to the global roll of the helix group

  • The roll of a helix group is given with respect to the origin of the helix group and represents the orientation of the entire group of helices
  • The local roll of a helix is given with respect to the helix's center
    These don't line up unless the helix is at the origin of its helix group

It's not entirely clear that the roll_of_helix function of a Design even has a valid use-case

After the changes, the design is exported properly

image

image

Related Issue

Issue #309

@DanielHader DanielHader deleted the 309-account-for-helix-group-rotation-properly-in-oxdnaoxview-export branch October 21, 2024 19:59
@dave-doty dave-doty restored the 309-account-for-helix-group-rotation-properly-in-oxdnaoxview-export branch October 21, 2024 20:40
@dave-doty dave-doty reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants