Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hero image tilt #99

Merged
merged 3 commits into from
Sep 17, 2023
Merged

Fix hero image tilt #99

merged 3 commits into from
Sep 17, 2023

Conversation

antonio-gg-dev
Copy link
Member

No description provided.

@antonio-gg-dev antonio-gg-dev added the bug Something isn't working label Sep 17, 2023
@antonio-gg-dev antonio-gg-dev self-assigned this Sep 17, 2023
@fabriziofs
Copy link
Collaborator

fabriziofs commented Sep 17, 2023

@Tito-Kati what was the bug and hoy can i test it? 🤔

@fabriziofs
Copy link
Collaborator

fabriziofs commented Sep 17, 2023

I'm having a problema with this, if i launch the app with docs:dev the hero image tilt functionality don't work 😢 but if I execute docs:preview the tilt works just fine 🤔

@Tito-Kati can you try it in your local? thx!

@antonio-gg-dev
Copy link
Member Author

I'm having a problema with this, if i launch the app with docs:dev the hero image tilt functionality don't work 😢 but if I execute docs:preview the tilt works just fine 🤔

@Tito-Kati can you try it in your local? thx!

You're right, and all this time I was forgetting that I have the Vue lifecycle hooks available to ensure everything is ready to add the animation. I've just fixed it.

@Chemaclass Chemaclass merged commit 03d3438 into main Sep 17, 2023
7 checks passed
@Chemaclass Chemaclass deleted the fix-logo-tilt branch September 17, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants