Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unset setup functions #94

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Unset setup functions #94

merged 4 commits into from
Sep 15, 2023

Conversation

Chemaclass
Copy link
Member

📚 Description

Discovered after merging #92 CC: @cmayo

🔖 Changes

  • Unset the setup/tearDown functions after each test/script

TODO: Missing tests for cleanSetUpAndTearDownAfterScript() and cleanSetUpAndTearDownAfterTest() in a follow up. Anybody can pick this up! ;)

@Chemaclass Chemaclass added the bug Something isn't working label Sep 15, 2023
fabriziofs
fabriziofs approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@fabriziofs fabriziofs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@Chemaclass Chemaclass merged commit fd5a3d7 into main Sep 15, 2023
7 checks passed
@Chemaclass Chemaclass deleted the fix/unset-setup-functions branch September 15, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziofs fabriziofs fabriziofs approved these changes

@khru khru Awaiting requested review from khru

@JesusValera JesusValera Awaiting requested review from JesusValera

@antonio-gg-dev antonio-gg-dev Awaiting requested review from antonio-gg-dev

Assignees

@Chemaclass Chemaclass

@khru khru

@JesusValera JesusValera

@fabriziofs fabriziofs

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Chemaclass @fabriziofs @khru @JesusValera