Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve render file header on verbose #376

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

Chemaclass
Copy link
Member

@Chemaclass Chemaclass commented Oct 13, 2024

🔖 Changes

  • Add the Running $script text always when verbose is enabled
    • Make it bold

🖼️ Screenshots

No verbose

Screenshot 2024-10-13 at 13 48 52

Verbose

Simple

Screenshot 2024-10-13 at 13 49 32

Detailed

Screenshot 2024-10-13 at 13 49 45

@Chemaclass Chemaclass added the enhancement New feature or request label Oct 13, 2024
@Chemaclass Chemaclass self-assigned this Oct 13, 2024
@Chemaclass Chemaclass force-pushed the feat/improve-render-file-header-on-verbose branch from dafccb2 to 303fa7e Compare October 13, 2024 11:40
@Chemaclass Chemaclass marked this pull request as draft October 13, 2024 11:41
@Chemaclass Chemaclass force-pushed the feat/improve-render-file-header-on-verbose branch from 303fa7e to 5a370f7 Compare October 13, 2024 11:48
@Chemaclass Chemaclass marked this pull request as ready for review October 14, 2024 17:13
@Chemaclass Chemaclass force-pushed the feat/improve-render-file-header-on-verbose branch from c949710 to 238d570 Compare October 14, 2024 17:14
Comment on lines -50 to +34
format_summary_value "1 failed" ", 1 total"
format_summary_value "0 failed" ", 0 total"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional, because a command not found. Context:

function test_error() {
  # before we had this as a way to find out that a command did not exist
  invalid_function_name
  assert_general_error

  # now bashunit is clever enough to know that a command does not exist by itself, 
  # without the need of an assertion afterwards
  invalid_function_name arg1 arg2
}

For this reason, there are no assertions in this test. Just a failing test.

@Chemaclass Chemaclass enabled auto-merge October 14, 2024 17:21
@Chemaclass Chemaclass merged commit 4c33046 into main Oct 14, 2024
13 checks passed
@Chemaclass Chemaclass deleted the feat/improve-render-file-header-on-verbose branch October 14, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants