Stop runner when found duplicate functions #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chemaclass
requested review from
khru,
JesusValera,
antonio-gg-dev and
fabriziofs
Chemaclass
added
enhancement
khru
requested changes
Sep 18, 2023
There was a problem hiding this comment.
Why if there is duplicated the exit code it's 0 at the end of the execution of bashunit.
test to prove it:
function test_with_duplicates_should_end_with_error_code() {
assertGeneralError "$(./bashunit "$(dirname "${BASH_SOURCE[0]}")/fixtures/duplicate_functions.sh")"
}
Command appears to be unreachable. Check usage (or ignore if invoked indirectly). [SC2317]
Chemaclass
force-pushed
the
feat/stop-exec-when-found-duplicate
branch
from
4260418
to
2064653
Compare
Chemaclass
force-pushed
the
feat/stop-exec-when-found-duplicate
branch
from
6eeb95a
to
fbb540d
Compare
antonio-gg-dev
requested changes
Sep 19, 2023
I've tried different approaches, but I couldn’t make this happen... Maybe you could try this out. What about working on this idea in a follow up PR to unblock the changes in this one? |
antonio-gg-dev
requested changes
Sep 19, 2023
antonio-gg-dev
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Issue: #56
Stop the execution of the test runner if you have two tests with the same name.
🔖 Changes
🖼️ Screenshots
Example:
🏗️ TODO
This current implementation works only when using the syntax
function foo () {..., but in bash you can define functions withoutfunctionand without the parentheses, so these two forms should also be valid and implemented in a follow up PRyourFunc() { ...function yourFunc { ...