feat(*): add custom password prompt for KMD and Mnemonic #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are scenarios where customsing window.prompt are needed: - window.prompt isn't supported, for example, on macOS WebKit - a better UI to display the message To implement this change, I have: - add options to customise the prompt to KMD and Mnemonic wallets - when the option isn't set, fallback to the default window.prompt
drichar
requested changes
Dec 4, 2024
There was a problem hiding this comment.
The only change I would like to see is to have the promptForPassword property be optional. Then it would be a non-breaking change and anyone currently using KMD and Mnemonic wallets in their projects would not need to do anything to continue with the default behavior (using window.prompt).
Other than that it looks great.
drichar
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Ah I apologize! All the options are already optional due to Partial 😅
So yeah this looks good to merge. Thank you again for the contribution @PatrickDinh! I'll ship the next release with this feature.
drichar
changed the title
drichar
added a commit
that referenced
this pull request
Dec 5, 2024
Two tests that were added upstream in PR #322 instantiate wallets without the `networks` property, introduced on the current `v4` branch. This change adds the `networks` property to `MnemonicWallet` and `KmdWallet`, ensuring proper initialization and tests passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scenarios where customising window.prompt are needed:
To implement this change: