https://github.com/TwistedInteractive/author_roles/issues/28 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add a new commit that adds a new version to the mta.xml file please ? Thanks! |
|
done |
|
Thanks! Are any other PR still needed ? |
| @@ -21,5 +21,8 @@ | |||
| to Symphony to make sure the 'Author Roles'-extension is executed as last, after all other extensions have | |||
| made their possible modifications to the navigation. Read the readme for more details. | |||
| </release> | |||
| <release version="1.0" date="2016-05-17" min="2.3"> | |||
There was a problem hiding this comment.
This is wrong. Should be version 1.3.0. New version goes at the top.. Sorry!
There was a problem hiding this comment.
And could you also add max="2.x.x" ? Thanks!
| <release version="1.0" date="2011-03-17" min="2.2" max="2.2.5" /> | ||
| <release version="1.1" date="2012-05-08" min="2.3" /> | ||
| <release version="1.3" date="2016-05-17" min="2.3" max="2.6.7"> | ||
| Updated `...nce()->Author->isD...` to `...nce()->Author()->isD...` per [migration guide](https://github.com/symphonycms/symphony-2/wiki/Migration-Guide-to-2.5-for-Developers#properties). |
There was a problem hiding this comment.
max should be "2.x.x" as this is the best practice right now. The 2.x series will not break anything.
|
See my new notes! Are any other PR still needed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.