-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test pre-releases instead of nightly and update actions #681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a really good idea, thanks @devmotion!
Is there a way to see from the CI logs what the actual Julia version is that's being used? If not, might be good to print it out.
It's shown in the logs of the setup-julia step, e.g. https://github.com/TuringLang/DynamicPPL.jl/actions/runs/11158554561/job/31015074600?pr=681#step:3:10 |
It seems the Julia compat entry of DynamicPPL has been incorrect for ~2 years: https://github.com/TuringLang/AbstractPPL.jl/blob/1cbcd1c39547bb17732b33d2b2f7aef1edc818af/Project.toml#L21 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
=======================================
Coverage 77.69% 77.69%
=======================================
Files 29 29
Lines 3591 3591
=======================================
Hits 2790 2790
Misses 801 801 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11159655625Details
💛 - Coveralls |
With setup-julia@v2 we can test
min
(minimum version supported) andpre
(pre-releases). I think the latter might be more stable and more relevant than testingnightly
.