deprecation: added check for favicon in html head #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #77 - ghost_head handles favicons so we should check that themes aren’t still including them in the html head
kirrg001
changed the title
|
Will look at this soon 👍 Thanks! |
|
@CriticalRespawn If you want, you can rebase this PR :) |
# Conflicts: # lib/spec.js
|
@kirrg001 Really sorry for the delay in getting back round to this! I'm not sure why Travis is failing, any help on that front would be appreciated :) |
kirrg001
reviewed
Aug 7, 2018
lib/spec.js
Outdated
| @@ -75,6 +75,376 @@ templates = [ | |||
|
|
|||
| // @TODO: register rules in each checker! | |||
| rules = { | |||
| <<<<<<< HEAD | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
kirrg001
reviewed
Aug 7, 2018
| @@ -75,6 +75,374 @@ templates = [ | |||
|
|
|||
| // @TODO: register rules in each checker! | |||
| rules = { | |||
| "GS001-DEPR-PURL": { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This reverts commit 6af6941.
# Conflicts: # lib/spec.js
|
This PR is getting messy. I'm not sure what the problem is, will close and reopen a new PR in the future. |
ghost
closed this
ghost
deleted the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #77
still including them in the html head