chore: migrate IFrame component to functional component #21677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:all
andyarn lint
)npx nx graph
doesn't show any task graphs either, I wonder if Nx is misconfigured.We appreciate your contribution!
While looking at the codebase, I found:
head
element that, on re-render, would wreck havoc on performance thanks to reconstructing all of the CSS stylesiframe
componentI figured I'd see if I could help with these issues, so I took a stab at it. I loaded the signup page and did a comparison against both the production tab and the development tab without my changes and it seemed to work fine.