Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated compose.yml files for Dev Container #21659

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

cmraible
Copy link
Collaborator

ref https://linear.app/ghost/issue/ENG-1785/consolidate-dev-container-composeyml-with-the-root-level-composeyml

  • We currently have two compose.yml files:
    • .devcontainer/compose.yml: used for the Dev Container
    • compose.yml: used for local development with docker compose
  • The Dev Container compose file does need some additional configuration, but most of this code is duplicated from the root level compose.yml file
  • This commit removes this duplication by using both compose files in the Dev Container setup, so it will base the compose configuration on the root level, and then extend it with the Dev Container specific configuration
  • This way any updates to the root level compose file will also be available and reflected in the Dev Container setup without having to make the change twice.

ref https://linear.app/ghost/issue/ENG-1785/consolidate-dev-container-composeyml-with-the-root-level-composeyml

- We currently have two compose.yml files:
    - .devcontainer/compose.yml: used for the Dev Container
    - compose.yml: used for local development with docker compose
- The Dev Container compose file does need some additional configuration, but most of this code is duplicated from the root level compose.yml file
- This commit removes this duplication by using both compose files in the Dev Container setup, so it will base the compose configuration on the root level, and then extend it with the Dev Container specific configuration
- This way any updates to the root level compose file will also be available and reflected in the Dev Container setup without having to make the change twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant