Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ballot Measures (single column) added #92

Merged
merged 29 commits into from
Aug 29, 2022

Conversation

stratofax
Copy link
Collaborator

Today's single-precinct ballot includes:

  • Correct voting instructions for both plurality and "n of m" candidate contests
  • Party abbreviations, below candidate names, where available
  • Ballot measures in a single column layout
  • Minor layout and spacing improvements

The ballot was generated with the command:

ballotmaker demo

All automated tests (pytest and linting on Python 3.8, 3.9 and 3.10 on Mac, Windows, and Linux) pass -- that's 9 total automated tests, all green on my fork. Ready to merge!

@stratofax stratofax added the enhancement New feature or request label Aug 26, 2022
@stratofax stratofax requested a review from ion-oset August 26, 2022 16:10
@stratofax stratofax self-assigned this Aug 26, 2022
@ion-oset
Copy link
Collaborator

ion-oset commented Aug 26, 2022

@stratofax the tests GitHub actions started have been running for several hours. I'm assuming they are blocked or caught in a loop. I've tried running them locally and they do the same thing. The test that hangs is this test_demo. I'm seeing similar results when I run ballotmaker demo directly.

Edit: Found the immediate issue, though not the ultimate cause. This code is in an infinite loop because path_finder has reached the filesystem root, and the parent of / is itself.

    while path_finder.name != self.package_name:
        path_finder = path_finder.parent

Note: I cancelled the build tasks.

@stratofax stratofax requested review from ion-oset and removed request for ion-oset August 26, 2022 22:06
@stratofax
Copy link
Collaborator Author

@ion-oset I'd like to merge this onto main before I add any more code. Thanks again for your excellent and careful review.

@stratofax stratofax merged commit 06a6587 into TrustTheVote-Project:dev-make-flat Aug 29, 2022
Copy link
Collaborator

@ion-oset ion-oset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments added since you merged. They are mostly informational, so I'm posting them anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants