Scroll button functionality #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jenniferchen11
commented
Jan 20, 2023
•
jenniferchen11
commented
✅ Deploy Preview for gifted-fermat-a1fc62 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
of button
justinyaodu
suggested changes
Jan 25, 2023
components/ScrollButton.tsx
Outdated
|
|
||
| import CustomImage from "./CustomImage"; | ||
|
|
||
| export default function Navbar() { |
There was a problem hiding this comment.
Looks like this should be named ScrollButton? Although tbh I make this mistake everywhere and the name doesn't actually matter 😅
There was a problem hiding this comment.
LMAO i copied and pasted from another file and forgot to change...
navidboloorian
suggested changes
Jan 30, 2023
|
@navidboloorian For some reason the icons have to be PNGs (I tried it with the SVG and some of the properties cannot be applied to it). Could you take another look at it and let me know if the image quality is noticeably low? |
navidboloorian
approved these changes
Feb 1, 2023
justinyaodu
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.