Reset Password #89
Reset Password #89
Conversation
|
Visit the preview URL for this PR (updated for commit ba0e108): https://pia-dev-60cea--pr89-feature-vs2961-react-ojhdflu8.web.app (expires Mon, 22 Apr 2024 19:18:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b780ee12a240535f7ca0729d49968573a1f3e284 |
| </Button> | ||
| {resetSent && ( | ||
| <h1 className="mt-1 flex items-center text-sm font-light text-green-700"> | ||
| <CheckCircle2 className="mr-1 text-sm" /> A reset password has been sent to your |
There was a problem hiding this comment.
This should only popup if the reset email was sent properly. If I were to try to request a password for an account that we don't have an email for then we need some sort of message for that.
There was a problem hiding this comment.
Though I would like to note when I tried using an email that isn't associated with an account it never sent the password reset link which is good.
There was a problem hiding this comment.
I assumed that this was a sort of security measure, so that someone couldn't just figure out what emails do and don't have an account. This is inherently built into the firebase function that sends the reset emails.
There was a problem hiding this comment.
There are people that take this approach, where it says something like "A reset password was sent if your email was found in the database"
There was a problem hiding this comment.
That is a good point. I think the message you suggested will work.
Tracking Info
Resolves #83
Changes
Added forgot password page
Testing
Created an account with my email, and then tried the forget password function.
Confirmation of Change