Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/andrewzpu/program page #62

Merged
merged 21 commits into from
Apr 15, 2024
Merged

Conversation

andrewzpu
Copy link
Contributor

@andrewzpu andrewzpu commented Feb 26, 2024

Tracking Info

Resolves #31
Resolves #44
Resolves #47

Changes

Created layout Programs Card UI element and Programs page.
Implemented different layouts for different screen sizes
Added some more settings to tailwind config and global.css

Created backend route to get list of all existing programs.

Connected programs page to backend route to visually display all program data

Testing

Ran on my own local host
Tested different size screens using device toolbar in developer view

Confirmation of Change

Standard View
image

Tablet View
image

Mobile View
image

Extra Large View
image

Backend Route Result
image

Programs page with database program data populated
image

Notes:
Card color in populated data is saved as #AEFFEA, this is not the default color
Student counts for each card is currently commented out until this data is added to the program schema

@andrewzpu andrewzpu requested a review from adhi0331 as a code owner February 26, 2024 02:59
Copy link

github-actions bot commented Feb 26, 2024

Visit the preview URL for this PR (updated for commit a79c54f):

https://pia-dev-60cea--pr62-feature-andrewzpu-pr-tlrgoicf.web.app

(expires Mon, 22 Apr 2024 15:54:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b780ee12a240535f7ca0729d49968573a1f3e284

@adhi0331 adhi0331 requested review from lisasiliu and vs2961 March 6, 2024 17:51
@adhi0331 adhi0331 removed the request for review from vs2961 April 9, 2024 22:58
@adhi0331 adhi0331 requested a review from mraysu April 9, 2024 22:58
Copy link
Contributor

@mraysu mraysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean!

@andrewzpu andrewzpu force-pushed the feature/andrewzpu/program-page branch from bc3a144 to f34bd33 Compare April 15, 2024 02:33
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change

frontend/src/api/requests.ts Outdated Show resolved Hide resolved
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@adhi0331 adhi0331 merged commit f204c4f into main Apr 15, 2024
4 checks passed
@adhi0331 adhi0331 deleted the feature/andrewzpu/program-page branch April 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants