Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Student Route Connected with Frontend #61

Closed
wants to merge 12 commits into from

Conversation

aaronchan32
Copy link
Member

@aaronchan32 aaronchan32 commented Feb 17, 2024

Tracking Info

Resolves #50 and #18

Changes

  • Added edit student backend route and connected with frontend
  • Included changes for creating students Feature/mraysu/add students backend #57 and getting all student information Route to get all student information #53
  • Added example in frontend/src/pages/home.tsx so that the page fetches all student data and displays a list of students with their corresponding view profile button to edit the student data. Please make sure to add a student first!
  • Updated default layout in frontend/src/pages/_app.tsx to use the Navigation component. The login/signup components are specified to use the Landing component as a layout

Testing

  • As mentioned in Michael's PR: Feature/mraysu/add students backend #57 please add the following environment variables:
    • FRONTEND_ORIGIN field in backend/.env (Ex. FRONTEND_ORIGIN = "http://localhost:3000"). Allows for backend to accept requests from the frontend URL.
    • NEXT_PUBLIC_API_BASE_URL field in frontend/.env (Ex. NEXT_PUBLIC_API_BASE_URL="http://localhost:4000/api"). URL prefix for sending requests to the backend. Be sure to include the route prefix base path "/api"

Confirmation of Change

image image

Note: We should display errors in a more user-friendly way such as adding a toast to the top of the screen or adding error labels in the form fields. We should have designs for loading state and when the data is empty.

Copy link

github-actions bot commented Feb 19, 2024

Visit the preview URL for this PR (updated for commit cdedc9a):

https://pia-dev-60cea--pr61-feature-aaronchan32-uj0vjxkj.web.app

(expires Thu, 29 Feb 2024 18:50:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b780ee12a240535f7ca0729d49968573a1f3e284

…into feature/aaronchan32/edit-student-route
@adhi0331
Copy link
Member

Resolved in Home Page 1.5 PR

@adhi0331 adhi0331 closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Edit Student Information] - Create a backend route that allows you to edit an existing profile
2 participants