-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit Student Route Connected with Frontend #61
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronchan32
had a problem deploying
to
Preview
February 17, 2024 08:02 — with
GitHub Actions
Failure
aaronchan32
had a problem deploying
to
Preview
February 17, 2024 08:21 — with
GitHub Actions
Failure
aaronchan32
had a problem deploying
to
Preview
February 18, 2024 00:37 — with
GitHub Actions
Failure
…into feature/aaronchan32/edit-student-route
Visit the preview URL for this PR (updated for commit cdedc9a): https://pia-dev-60cea--pr61-feature-aaronchan32-uj0vjxkj.web.app (expires Thu, 29 Feb 2024 18:50:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b780ee12a240535f7ca0729d49968573a1f3e284 |
…into feature/aaronchan32/edit-student-route
Merged
Resolved in Home Page 1.5 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #50 and #18
Changes
frontend/src/pages/home.tsx
so that the page fetches all student data and displays a list of students with their corresponding view profile button to edit the student data. Please make sure to add a student first!frontend/src/pages/_app.tsx
to use the Navigation component. The login/signup components are specified to use the Landing component as a layoutTesting
backend/.env
(Ex. FRONTEND_ORIGIN = "http://localhost:3000"). Allows for backend to accept requests from the frontend URL.frontend/.env
(Ex. NEXT_PUBLIC_API_BASE_URL="http://localhost:4000/api"). URL prefix for sending requests to the backend. Be sure to include the route prefix base path "/api"Confirmation of Change
Note: We should display errors in a more user-friendly way such as adding a toast to the top of the screen or adding error labels in the form fields. We should have designs for loading state and when the data is empty.