Add firebase login route #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird, Parth is the default codeowner now, might want to look into that. |
parth4apple
had a problem deploying
to
Preview
GitHub Actions
Failure
parth4apple
had a problem deploying
to
Preview
GitHub Actions
Failure
|
Visit the preview URL for this PR (updated for commit 4ca8db9): https://pia-dev-60cea--pr56-feature-vs2961-login-yr63jaiz.web.app (expires Fri, 01 Mar 2024 00:45:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b780ee12a240535f7ca0729d49968573a1f3e284 |
adhi0331
reviewed
Feb 21, 2024
adhi0331
approved these changes
Feb 23, 2024
| const errors = validationResult(req); | ||
| validationErrorParser(errors); | ||
|
|
||
| const { email, password } = req.body; |
There was a problem hiding this comment.
Do we want to consider encrypting the password so that it's protected? I'm sure there some basic packages we could use for encryption/decryption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #38
Changes
Added route for login
Testing
Tested it with Postman.
Call
localhost:4000/api/user/loginwithConfirmation of Change
Run the backend and run with postman.