Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add login page #36

Merged
merged 15 commits into from
Feb 23, 2024
Merged

Add login page #36

merged 15 commits into from
Feb 23, 2024

Conversation

vs2961
Copy link
Contributor

@vs2961 vs2961 commented Jan 23, 2024 •
edited
Loading

Tracking Info

Resolves #27

Changes

Added the Login Page for mobile and web views.

Testing

Checked the pages against Figma.

Confirmation of Change

Screenshot 2024-01-25 at 9 39 24 AM
Screenshot 2024-01-25 at 9 39 35 AM

@vs2961 vs2961 marked this pull request as ready for review January 25, 2024 17:41
@vs2961 vs2961 requested a review from adhi0331 as a code owner January 25, 2024 17:41
@vs2961
Copy link
Contributor Author

vs2961 commented Jan 25, 2024

The text boxes are a little different, but I just used whatever was available in the repo from previous PRs.

aaronchan32
aaronchan32 approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@aaronchan32 aaronchan32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

adhi0331
adhi0331 requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need that one minor change to the Home page navbar and should be good to merge.

frontend/src/pages/_app.tsx Outdated Show resolved Hide resolved
frontend/src/pages/_app.tsx Outdated Show resolved Hide resolved
@vs2961 vs2961 requested a review from parth4apple as a code owner February 13, 2024 00:33
@vs2961
Copy link
Contributor Author

vs2961 commented Feb 13, 2024

Not sure what the deployment issue is about, the page works fine on my end.

parth4apple
parth4apple reviewed Feb 13, 2024
View reviewed changes
frontend/src/pages/profile.tsx Outdated
/>
<Textfield
register={register}
setValue={setValue}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployment fails because the frontend build fails (can check that by running npm run build).
The issue seems to be setValue does not exist on Textfield, so if you change this line to setCalendarValue={setValue} it'll fix the build and make the calendar popover work.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit fa97bb5):

https://pia-dev-60cea--pr36-feature-vs2961-login-ct81y5v8.web.app

(expires Fri, 01 Mar 2024 00:53:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b780ee12a240535f7ca0729d49968573a1f3e284

adhi0331

This comment was marked as duplicate.

Sign in to view

@adhi0331 adhi0331 dismissed their stale review February 14, 2024 04:58

Found some changes

adhi0331
adhi0331 reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some basic comments

frontend/src/pages/index.tsx Outdated Show resolved Hide resolved
frontend/src/pages/_app.tsx Outdated Show resolved Hide resolved
@vs2961 vs2961 requested a review from adhi0331 February 23, 2024 15:02
adhi0331
adhi0331 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@adhi0331 adhi0331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@adhi0331 adhi0331 merged commit 12fb60f into main Feb 23, 2024
4 checks passed
@adhi0331 adhi0331 deleted the feature/vs2961/LoginPage branch February 23, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parth4apple parth4apple parth4apple left review comments

@adhi0331 adhi0331 adhi0331 approved these changes

@aaronchan32 aaronchan32 aaronchan32 approved these changes

@andrewzpu andrewzpu Awaiting requested review from andrewzpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Login to User Account] - Create a UI for the sign in (Landing Page)
4 participants
@vs2961 @aaronchan32 @parth4apple @adhi0331