Added Button Components #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhi0331
approved these changes
Jan 21, 2024
frontend/src/components/Button.tsx
Outdated
| { label, kind = "primary", size = "default", disabled = false, className, ...props }: ButtonProps, | ||
| ref, | ||
| ) { | ||
| let buttonClass = styles.button; |
There was a problem hiding this comment.
We're getting this error because styles is some any type by default. Here is a hacky solution that you could try
. Basically we just need to create a ButtonStyles type and then import the styles as that type (see const buttonStyles). I tested it and it shouldn't break the functionality of the button component. Go ahead and give this a try and see if the github action check passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking Info
Resolves #3
Changes
Created Button components (all 8 types of standard buttons + 1 tag button)
Added some global css (for colors) and applied them globally by setting up _app.tsx
Testing
Tested by adding buttons to index.tsx to simulate:
Buttons function correctly
Button components have access to global css variables. When global css variables are changed, the button components also change.
Confirmation of Change
Again, buttons can be seen here:
Can be added to pages in this format: