-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navbar admin mode #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Pratyush! Just some styling issues with the top navbar, the sideline sidekick text shouldn't be stacking, and the search bar isn't centered, also the profile icon isn't showing. Also, if you could put the components and their styles into a dedicated components folder. I think these issues just occur on smaller screens.Thanks!
Great work!! On top of the styling issues with the top navbar, I noticed the logos along the side bar are misaligned, "Home" seems to be a lighter weight boldness than "Search" and "General Principles", and the spacing between categories under General Principles seems stacked tighter together than the Figma designs intended. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visit the preview URL for this PR (updated for commit db6d416): https://sideline-sidekick-app--pr34-feature-pratyush1718-58j0eg17.web.app (expires Mon, 06 May 2024 04:13:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c79d7b8d45dd65a5ed497bfab058d62b30d420cc |
All the above comments have been addressed. @Anthonyp0329 and I have decided to push without the arrow direction change for now. |
Tracking Info
Resolves #29
Changes
Added horizontal and vertical nav bar for admin node
Testing
tested on http://localhost:3000/
Confirmation of Change