Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar admin mode #34

Merged
merged 5 commits into from
May 2, 2024
Merged

navbar admin mode #34

merged 5 commits into from
May 2, 2024

Conversation

pratyush1718
Copy link
Contributor

Tracking Info

Resolves #29

Changes

Added horizontal and vertical nav bar for admin node

Testing

tested on http://localhost:3000/

Confirmation of Change

image

Copy link
Collaborator

@Anthonyp0329 Anthonyp0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Pratyush! Just some styling issues with the top navbar, the sideline sidekick text shouldn't be stacking, and the search bar isn't centered, also the profile icon isn't showing. Also, if you could put the components and their styles into a dedicated components folder. I think these issues just occur on smaller screens.Thanks!
image

@Anthonyp0329 Anthonyp0329 requested review from a team, r800360, EdwardLinS and meganleongg and removed request for a team, meganleongg, r800360 and EdwardLinS April 22, 2024 03:59
@meganleongg
Copy link
Contributor

Great work!! On top of the styling issues with the top navbar, I noticed the logos along the side bar are misaligned, "Home" seems to be a lighter weight boldness than "Search" and "General Principles", and the spacing between categories under General Principles seems stacked tighter together than the Figma designs intended.

Copy link
Contributor

@LillianHo5 LillianHo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Aside from what was mentioned in the above comments, I noticed that the chevron/arrow should be pointing right when inactive instead of pointing down from the Figma. It also seems that the "All" should be bolded.
Screenshot 2024-04-22 at 6 28 25 PM

Copy link

Visit the preview URL for this PR (updated for commit db6d416):

https://sideline-sidekick-app--pr34-feature-pratyush1718-58j0eg17.web.app

(expires Mon, 06 May 2024 04:13:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c79d7b8d45dd65a5ed497bfab058d62b30d420cc

@pratyush1718
Copy link
Contributor Author

All the above comments have been addressed. @Anthonyp0329 and I have decided to push without the arrow direction change for now.

@Anthonyp0329 Anthonyp0329 merged commit f129d52 into main May 2, 2024
4 checks passed
@Anthonyp0329 Anthonyp0329 deleted the feature/pratyush1718/adminNavBar branch May 2, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar + Page Routing
4 participants