Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewall #31

Closed
wants to merge 12 commits into from
Closed

Viewall #31

wants to merge 12 commits into from

Conversation

PiXlRAM
Copy link
Member

@PiXlRAM PiXlRAM commented Apr 17, 2024

Tracking Info

Resolves #19

Changes

Made view all page, made pressable card views, routed from home page to view all page

Testing

Checked on ios and android.

Confirmation of Change

image

After clicking on card with no content in card:

image

After clicking on card with content in card:

image

@PiXlRAM PiXlRAM requested a review from Anthonyp0329 as a code owner April 17, 2024 21:44
Copy link
Collaborator

@Anthonyp0329 Anthonyp0329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome!!! Great work! Make sure to resolve that issue that pops up, the "no two children" one, as I'm seeing this when testing. Also, resolve linter errors, but should be great to merge after this.

@Anthonyp0329 Anthonyp0329 requested review from a team, r800360, EdwardLinS and meganleongg and removed request for a team and meganleongg April 18, 2024 22:57
Copy link
Contributor

@EdwardLinS EdwardLinS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vinayak! Fantastic job, this looks great! Just a tiny few minor issues though. It seems the last card in the View All list gets cut off by the bottom navigation bar.

image

Other than that and Andrew's requests, everything looks great! Really nice job 👍

Copy link

Visit the preview URL for this PR (updated for commit a40ea13):

https://sideline-sidekick-app--pr31-viewall-jrhzv2gd.web.app

(expires Tue, 07 May 2024 02:01:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c79d7b8d45dd65a5ed497bfab058d62b30d420cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View All Components
3 participants