Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-8602 update bash to 5.2 #138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

OS-8602 update bash to 5.2 #138

wants to merge 2 commits into from

Conversation

tsoome
Copy link
Contributor

@tsoome tsoome commented Nov 21, 2024

I used the patches collected in openindiana oi-userland tree (just because I happen to have that repo clone). The disable-function-import.diff is from current bash (with small update because of context change). Also had to update diffs a bit to match our patch procedure (-p1).

@danmcd
Copy link
Contributor

danmcd commented Nov 21, 2024

1.) The testing burden for an upgrade like this is high. We ship:

  • Tons of bash scripts
  • Tons of autocomplete scripts (no idea how backward-compatible bash versions are, esp jumping from 4.x to 5.x
  • shlibs for bash.

2.) The OmniOS build of bash has FAR FEWER patches, but it's very possible its fetch-patches script: https://github.com/omniosorg/omnios-build/blob/master/build/bash/patches/fetch-patches does that heavy lifting.

@tsoome
Copy link
Contributor Author

tsoome commented Nov 21, 2024

1.) The testing burden for an upgrade like this is high. We ship:

  • Tons of bash scripts
  • Tons of autocomplete scripts (no idea how backward-compatible bash versions are, esp jumping from 4.x to 5.x
  • shlibs for bash.

ok, this sounds like for quick fix it is still better to poke that old horse and have more time for upgrade.

2.) The OmniOS build of bash has FAR FEWER patches, but it's very possible its fetch-patches script: https://github.com/omniosorg/omnios-build/blob/master/build/bash/patches/fetch-patches does that heavy lifting.

Yes, the thing there is that they seem to publish tarball and then minor issues fixed in form of patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants