Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and use new theme/base #15

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

laceysanderson
Copy link
Member

@laceysanderson laceysanderson commented Mar 13, 2024

Issue #14

Motivation

Based on the changes made in TripalCultivate/TripalCultivate#8 we need to update all the packages.

What does this PR do?

Please describe each things this PR does. For example, a PR may 1) solve a specific bug, 2) create an automated test to ensure it doesn't return.

  1. Updates dependencies (i.e. Drupal version, Tripal Cultivate Base)
  2. Dockerfile now uses TripalCultivate base image instead of Tripal core
  3. Update all github action versions to remove warning about Node 20
  4. Update automated testing grid to include Drupal 10.2 and PHP 8.2
  5. Update all workflows to allow them to be manually triggered and to ensure they are run each night on the most recent changes in dependencies.

NOTE: This module is not yet compatible with Drupal 10.2 so the failing tests for that version of Drupal are expected. This will be fixed in Issue #16

Testing

Automated Testing

No additional automated testing needed for these changes.

Manual Testing

Describe in detail how someone should manually test this functionality.
Make sure to include whether they need to build a docker from scratch, create any records, etc.

  1. Check that the automated testing passes. This confirms changes to dependancies, workflows and the Dockerfile did not cause any issues.
  2. Build a docker image locally and run a container just to take a look at things.
    • everything is installed and chado is in a schema named testschema
    • the content types you expect are available (note: additionally the genetic and genomic will now be available).
    • confirm that the site is now themed green as expected for Tripal Cultivate.

@laceysanderson laceysanderson linked an issue Mar 13, 2024 that may be closed by this pull request
Copy link
Contributor

@carolyncaron carolyncaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lacey!

  1. Tests are only failing for Drupal 10.2 but this was already noted as an issue.
  2. Built a new docker image locally
    • Confirmed that Tripal Cultivate, TripalCultivate: Germplasm, TripalCultivate: Germplasm Collection were enabled
    • Chado is in a schema named testchado (which I'm pretty sure is what you meant 😉 )
    • Tripal content types available: General, Germplasm, Genomic, Genetic
    • The site is themed green

@laceysanderson laceysanderson merged commit 6cbc63b into 4.x Mar 14, 2024
5 of 8 checks passed
@laceysanderson laceysanderson deleted the g0.14-updateDependenciesAndTheme branch March 14, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

G0.14 Update dependancies to include new theme/base
2 participants