-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for debug input/output (hacked) #16
base: master
Are you sure you want to change the base?
Conversation
94434f5
to
3400eae
Compare
3400eae
to
7612204
Compare
This is closer to isolating the essential changes. It looks like there is still more work to do though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've changed the meaning of _Dbg_open_if_tty
and set inferior-tty
from the tty being read/write to being read only. Why was this necessary?
If for some reason you need a tty for reading, why not create new routines, instead change the behavior of these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm totally confused as to what you intend to do by this?
@@ -110,7 +110,7 @@ _Dbg_do_eval() { | |||
typeset -i _Dbg_rc | |||
if [[ -t $_Dbg_fdi ]] ; then | |||
_Dbg_set_dol_q $_Dbg_debugged_exit_code | |||
. $_Dbg_evalfile >&${_Dbg_fdi} | |||
. $_Dbg_evalfile >>"$_Dbg_tty" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is appending right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually the part that is totally hacked, since i could not figure out what to do with fdi's - I just added the actual file for testing.
So the vscode extension uses 2 named pipes (debugger in, debugger out), they are expected to be separated from debugged script's in/out/err (command line options). I will check soon, maybe the appending is not needed...
You are correct, I am having problems since for example I do not get the idea of "inferior tty". The |
With "inferior tty" I am just trying to follow gdb. See http://visualgdb.com/gdbreference/commands/tty There are two ways I see we could accommodate changed behavior. One way inside this repository is to add two directories new directories paralleling the Another possibility is just to keep a small set of patches outside and patch the code from those patches. That would work better if you wanted to patch not only for VSCode needs but also for different bash shells but down't want the bloat of the largely common sets of files that occurs among the different versions. |
7c4d1f9
to
40c80fb
Compare
07d8922
to
2c3849a
Compare
51719dc
to
318cf7e
Compare
No description provided.