-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gurubu-client): open graph image generator added #122
Open
hanifisenturk
wants to merge
7
commits into
Trendyol:main
Choose a base branch
from
hanifisenturk:feature/open-graph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
88d82ea
feat(app): open graph image generator added
hanifisenturk 811df44
fix(gurubu-client): unnecessary variable removed
hanifisenturk 53496ad
refactor(gurubu-client): open graph endpoint refactor
hanifisenturk 6cea698
refactor(gurubu-client): og image logic changed
hanifisenturk 7775918
Merge branch 'Trendyol:main' into feature/open-graph
hanifisenturk 6e07eda
Merge branch 'feature/open-graph' of github.com:hanifisenturk/gurubu …
hanifisenturk d416c7f
refactor(gurubu-client): robots.ts removed
hanifisenturk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
import { ImageResponse } from "next/og"; | ||
import { CSSProperties } from "react"; | ||
|
||
export const runtime = "edge"; | ||
|
||
const imageStyle: CSSProperties = { | ||
backgroundColor: "#ffffff", | ||
backgroundSize: "150px 150px", | ||
height: "100%", | ||
width: "100%", | ||
display: "flex", | ||
textAlign: "center", | ||
alignItems: "center", | ||
justifyContent: "center", | ||
flexDirection: "column", | ||
flexWrap: "nowrap", | ||
fontSize: "48px", | ||
}; | ||
|
||
const imageSize = { | ||
width: 1200, | ||
height: 630, | ||
}; | ||
|
||
export async function GET(request: Request) { | ||
try { | ||
const imageData = await fetch( | ||
new URL("../../../../public/logo-with-text.png", import.meta.url) | ||
).then((res) => res.arrayBuffer()); | ||
|
||
return new ImageResponse( | ||
( | ||
<div style={imageStyle}> | ||
{imageData && ( | ||
<img width={372} height={90} src={imageData as unknown as string} /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be great if we could make this place cleaner. src={imageData as unknown as string} |
||
)} | ||
Simple, fast and practical grooming. | ||
</div> | ||
), | ||
imageSize | ||
); | ||
} catch (e: any) { | ||
return new ImageResponse( | ||
( | ||
<div style={imageStyle}> | ||
<h1>GuruBu</h1> | ||
Simple, fast and practical grooming. | ||
</div> | ||
), | ||
imageSize | ||
); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { MetadataRoute } from "next"; | ||
|
||
export default function robots(): MetadataRoute.Robots { | ||
return { | ||
rules: { | ||
allow: ["/", "/api/og/*"], | ||
}, | ||
}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to take it as an ordinary picture?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mertcanaltin actually I thought that. As I used the edge runtime for this operation, all resources have to get with fetch api. This link explains that as well. Of course, if I used Node runtime, we can get the data via
fs.readFile
.