feat: table component #788

bariskaraca · 2024-01-30T06:23:37Z

Closes #142

* feat: table components initialized

* feat: added sticky last column * feat: added full story

* feat: fix css prettier issue

buseselvi · 2024-01-30T20:20:29Z

Great job! 🚀 Just, I think sorting works wrong. It looks right on the UI but should be working as ascending (A-Z / 1-9) sorting on the first click. It is working as Z-A / 9-1 in the storybook. Can we fix that? 🙏 @bariskaraca

* feat: add numeric sort to id column in story

src/components/table/bl-table.ts

src/components/table/bl-table.stories.mdx

src/components/table/bl-table.ts

src/components/table/table-cell/bl-table-cell.ts

src/components/table/bl-table.ts

* feat: Remove console log in story * feat: Change map to foreach for querySelectorAll * feat: Change story title to Table

src/components/table/table-cell/bl-table-cell.ts

buseselvi · 2024-02-01T19:57:59Z

When there is a disabled row that can't be selected, the table header checkbox should be indeterminate. We also did that in the Select Component as in the second picture below.

* feat: Refactor select all logic

* feat: Edit args table for table stories * feat: Remove nullish operator for closest

* feat: Add table stories

* feat: Edit sort function in story * feat: Add tooltip to table header in story

… into feature/datatable

* feat: Edit row selection story texts

* feat: Reset table scroll position on sort

buseselvi

Sorting icon already exists, it is the same as the sorting_default icon. Can we remove the newly added default one?

And in the UI Test, it seems there is a problem with the sticky headers and columns in the Firefox browser. Borders of sticky areas are not visible, can we check it?

* feat: add background-clip to cell and header cell

* feat: remove sorting default icon

AykutSarac · 2024-02-23T08:42:44Z

There's an issue with the cell corners and width/height:

src/components/table/bl-table.ts

src/components/table/table-header/bl-table-header.ts

src/components/table/table-cell/bl-table-cell.ts

src/components/table/bl-table.ts

src/components/table/table-body/bl-table-body.ts

src/components/table/table-cell/bl-table-cell.ts

src/components/table/table-header-cell/bl-table-header-cell.ts

src/components/table/table-header/bl-table-header.ts

src/components/table/table-row/bl-table-row.ts

…sticky-header attribute

buseselvi

I wrote it above but it may have been overlooked: In the UI Test, it seems there is a problem with the sticky headers and columns in the Firefox and Safari browsers. Borders of sticky areas are not visible, can we check it?

buseselvi · 2024-02-27T11:10:42Z

There's an issue with the cell corners and width/height:

and can we fix this radius issue, too? 🙏🏻

* feat: fix border issue

* feat: add last child control for shadow left

* feat: remove disabled control for all checked state

src/components/table/table-header-cell/bl-table-header-cell.ts

leventozen

Thank you to all the contributors and maintainers for your dedication and hard work on the table component. Your efforts have truly elevated our project to the next level. 🚀

github-actions · 2024-02-28T08:33:09Z

🎉 This PR is included in version 3.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions · 2024-05-02T11:58:38Z

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Saffet Barış Karaca and others added 2 commits January 8, 2024 14:35

feat: table component

bdbfd56

* feat: table components initialized

feat: table component

96e67ed

* feat: added sticky last column * feat: added full story

bariskaraca requested a review from ogunb January 30, 2024 06:24

feat: table component

dcfe2bf

* feat: fix css prettier issue

leventozen changed the title ~~Feature/datatable~~ feat: datatable component Jan 30, 2024

leventozen changed the title ~~feat: datatable component~~ feat: table component Jan 30, 2024

feat: table component

107b9cb

* feat: add numeric sort to id column in story

0o001 reviewed Jan 31, 2024

View reviewed changes

src/components/table/bl-table.ts Outdated Show resolved Hide resolved

AykutSarac requested changes Jan 31, 2024

View reviewed changes

bariskaraca and others added 3 commits January 31, 2024 17:55

feat: table component

bcd17df

* feat: Remove console log in story * feat: Change map to foreach for querySelectorAll * feat: Change story title to Table

refactor(table): improve the readability of selection logic

69b2e10

refactor(table): improve the readability of selection logic

7326d4c

0o001 reviewed Jan 31, 2024

View reviewed changes

src/components/table/table-cell/bl-table-cell.ts Outdated Show resolved Hide resolved

bariskaraca and others added 9 commits February 5, 2024 14:47

feat: table component

257f124

* feat: Refactor select all logic

feat: table component

bedf87b

* feat: Edit args table for table stories * feat: Remove nullish operator for closest

feat: table component

aa291f5

* feat: Add table stories

feat: table story

cf07014

* feat: Edit sort function in story * feat: Add tooltip to table header in story

docs(table): added missing stories

c0ec976

Merge branch 'feature/datatable' of https://github.com/Trendyol/baklava…

d2770e8

… into feature/datatable

feat: table story

ac275e4

* feat: Edit row selection story texts

feat: table component

d76c8d5

* feat: Reset table scroll position on sort

feat: edit table story title

54cb550

buseselvi self-requested a review February 20, 2024 13:19

buseselvi requested changes Feb 20, 2024

View reviewed changes

bariskaraca added 2 commits February 20, 2024 16:36

feat: table component

6bc4df1

* feat: add background-clip to cell and header cell

feat: table component

749cc56

* feat: remove sorting default icon

buseselvi approved these changes Feb 20, 2024

View reviewed changes

AykutSarac requested changes Feb 23, 2024

View reviewed changes

Merge branch 'next' into feature/datatable

e348470

leventozen self-requested a review February 26, 2024 07:22

Aykut Saraç added 2 commits February 26, 2024 17:00

chore(table): rename event and attributes

0db9f0e

chore(table): rename selectedValues attribute

5282e35

Enes5519 requested changes Feb 27, 2024

View reviewed changes

refactor(table): remove unneeded lifecyle methods & fix table header …

631531d

…sticky-header attribute

Enes5519 approved these changes Feb 27, 2024

View reviewed changes

buseselvi requested changes Feb 27, 2024

View reviewed changes

refactor(table): rename header sticky attribute

4d5406e

feat: table component

627b58b

* feat: fix border issue

Enes5519 approved these changes Feb 27, 2024

View reviewed changes

bariskaraca added 2 commits February 27, 2024 15:59

feat: table component

4e0adb8

* feat: add last child control for shadow left

feat: table component

e4f09a9

* feat: remove disabled control for all checked state

buseselvi approved these changes Feb 27, 2024

View reviewed changes

AykutSarac requested changes Feb 27, 2024

View reviewed changes

src/components/table/table-header-cell/bl-table-header-cell.ts Outdated Show resolved Hide resolved

src/components/table/table-header-cell/bl-table-header-cell.ts Outdated Show resolved Hide resolved

refactor(table): improve accessibility

03b0066

AykutSarac approved these changes Feb 27, 2024

View reviewed changes

leventozen approved these changes Feb 28, 2024

View reviewed changes

leventozen merged commit e1c54b9 into next Feb 28, 2024
7 checks passed

leventozen deleted the feature/datatable branch February 28, 2024 08:28

github-actions bot added the released on @beta label Feb 28, 2024

github-actions bot added the released label May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: table component #788

feat: table component #788

bariskaraca commented Jan 30, 2024 •

edited by leventozen

Loading

buseselvi commented Jan 30, 2024

buseselvi commented Feb 1, 2024

buseselvi left a comment •

edited

Loading

AykutSarac commented Feb 23, 2024

buseselvi left a comment

buseselvi commented Feb 27, 2024

leventozen left a comment

github-actions bot commented Feb 28, 2024

github-actions bot commented May 2, 2024

feat: table component #788

feat: table component #788

Conversation

bariskaraca commented Jan 30, 2024 • edited by leventozen Loading

buseselvi commented Jan 30, 2024

buseselvi commented Feb 1, 2024

buseselvi left a comment • edited Loading

Choose a reason for hiding this comment

AykutSarac commented Feb 23, 2024

buseselvi left a comment

Choose a reason for hiding this comment

buseselvi commented Feb 27, 2024

leventozen left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 28, 2024

github-actions bot commented May 2, 2024

bariskaraca commented Jan 30, 2024 •

edited by leventozen

Loading

buseselvi left a comment •

edited

Loading