-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): add search feature for select #759
Conversation
Great job! @erbilnas 🚀 I have a few notes:
|
Hey @buseselvi, thanks for your kind feedback!
For your feedback on this comment, the loading state isn't for typing but for monitoring the fetch process. For instance, if developers aim to display options through an API call, we need to provide them with the loading state. They can then modify the loading state as needed. We talked about it earlier. |
…g icon, unshow remove button when searching, show label if the placeholder is missing
…nd give padding, improve storybook for select
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got some comments but we can take care of them before stable. LGTM! 🚀
🎉 This PR is included in version 2.4.0-beta.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #265
I've pushed the commit unverified as I'm facing operating system-related test errors on my local machine. Despite my efforts, I couldn't resolve the issue. I've opened an issue on the relevant project for further investigation.
modernweb-dev/web#2589