Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): non label-fixed select breaks input styling #755

Closed
wants to merge 1 commit into from

Conversation

0o001
Copy link
Contributor

@0o001 0o001 commented Dec 23, 2023

Copy link
Contributor

@fatihhayri fatihhayri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also found a solution as follows.

:host([placeholder]) :where(.select-open, .selected) .label,
:host(:not([placeholder])) .selected .label {
  display: none;
}```

@ogunb
Copy link
Contributor

ogunb commented Dec 27, 2023

Hey @0o001, thanks for your contribution!

Looking at the UI review, it seems like we have some unwanted side effects. I'm closing this one in favor of #760.

@fatihhayri @erbilnas fyi.

@ogunb ogunb closed this Dec 27, 2023
@0o001 0o001 deleted the next-5 branch December 27, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants