Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): return single value for single select #677

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

AykutSarac
Copy link
Member

fixes #675

@AykutSarac AykutSarac requested a review from muratcorlu August 1, 2023 14:49
@AykutSarac AykutSarac added the breaking change Be cautious with merging this label Aug 2, 2023
@muratcorlu
Copy link
Contributor

Do you think we should make a major release (v3) for this?

@AykutSarac
Copy link
Member Author

I believe we should at least have one new component per major release or significant change, until that time such changes can wait unless it requires urgent fix.

@muratcorlu
Copy link
Contributor

Stable releases should last longer than a few months. Our consumers should not need to make a careful upgrade every few months. So I propose avoiding breaking changes as much as possible for a while, and collect those proposals in a backlog for a bigger major release.

We may consider to have another branch for major releases like next-major and we can merge breaking changes to that branch, but this will also add extra maintenance cost since we will need to sync other works from next branch to next-major continuously.

@AykutSarac
Copy link
Member Author

AykutSarac commented Aug 2, 2023

I think beta releases may contain breaking changes, after all they're neither minor or major release. We can note the list of breaking changes at the major release when it's out.

@muratcorlu
Copy link
Contributor

Yes, beta releases can have major releases. But we currently have only a single beta channel. If we merge this branch with a "breaking change" notice in commit message, then our next branch will release "v3.0.0-beta.1". Then when we merge next to main, we'll have a major stable release. there will be no chance to make a "v2.3.0" release.

@leventozen leventozen self-requested a review January 11, 2024 11:57
@leventozen leventozen merged commit 2304485 into next Jan 11, 2024
7 checks passed
@leventozen leventozen deleted the fix/select-single-value branch January 11, 2024 11:58
Copy link

🎉 This PR is included in version 2.4.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Jan 25, 2024
Copy link

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: bl-select should return value instead of array on single select
3 participants