Skip to content

Commit

Permalink
fix(select): add string to boolean converter for related prop (#775)
Browse files Browse the repository at this point in the history
No breaking change | Closes #774

Co-authored-by: Erbil Nas <[email protected]>
  • Loading branch information
erbilnas and Erbil Nas authored Jan 18, 2024
1 parent 008dd81 commit e032b7a
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion src/components/select/bl-select.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { FormControlMixin, requiredValidator } from "@open-wc/form-control";
import { FormValue } from "@open-wc/form-helpers";
import "element-internals-polyfill";
import { event, EventDispatcher } from "../../utilities/event";
import { stringBooleanConverter } from "../../utilities/string-boolean.converter";
import BlCheckbox from "../checkbox-group/checkbox/bl-checkbox";
import "../icon/bl-icon";
import style from "../select/bl-select.css";
Expand Down Expand Up @@ -171,7 +172,11 @@ export default class BlSelect<ValueType extends FormValue = string> extends Form
/**
* Display a loading icon in place of the search icon.
*/
@property({ type: Boolean, attribute: "search-bar-loading-state", reflect: true })
@property({
type: Boolean,
attribute: "search-bar-loading-state",
converter: stringBooleanConverter(),
})
searchBarLoadingState = false;

/**
Expand Down

0 comments on commit e032b7a

Please sign in to comment.