Skip to content

Commit

Permalink
Merge pull request #653 from Trendyol/next
Browse files Browse the repository at this point in the history
  • Loading branch information
muratcorlu authored Jul 14, 2023
2 parents 6f9d725 + 039af1e commit 5cbd553
Show file tree
Hide file tree
Showing 68 changed files with 4,290 additions and 3,007 deletions.
38 changes: 0 additions & 38 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

61 changes: 61 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
name: Bug report
description: Create a report to help us improve
title: "[BUG]: <Context of the issue>"
labels: bug
body:
- type: textarea
id: description
attributes:
label: Issue description
description: |
Describe the issue in as much detail as possible.
Tip: You can attach images or log files by clicking this area to highlight it and then dragging files into it.
placeholder: |
Steps to reproduce with below code sample:
1. do thing
2. click...
3. observe behavior
4. see error logs below
validations:
required: true
- type: textarea
id: media
attributes:
label: Media & Screenshots
description: Include screenshots or video of reproduction as much as possible
- type: input
id: baklava-version
attributes:
label: Baklava Version
description: What version of Baklava are you using?
placeholder: 2.1.0-beta.7
validations:
required: false
- type: textarea
id: os
attributes:
label: Operating system
description: Which OS does your application run on?
value: |
- OS: [e.g. iOS]:
- Browser [e.g. chrome, safari]:
- Any other details...
- type: dropdown
id: priority
attributes:
label: Priority this issue should have
description: Please be realistic. If you need to elaborate on your reasoning, please use the Issue description field above.
options:
- Low (slightly annoying)
- Medium (should be fixed soon)
- High (immediate attention needed)
validations:
required: true
- type: checkboxes
id: questions
attributes:
label: Please review the checkboxes that are applicable.
options:
- label: This issue is directly related to React
20 changes: 0 additions & 20 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Feature request
description: Suggest a new feature or enhancement for the library
title: "[Feature Request]: <Context of the feature request>"
body:
- type: textarea
id: problem-description
attributes:
label: Describe the problem or use case
description: |
Provide a detailed description of the problem or use case that the proposed feature aims to address.
For example: "When using the Baklava in scenario X, I encountered issues with..."
validations:
required: true
- type: textarea
id: solution-description
attributes:
label: Proposed solution
description: |
Describe your proposed solution or enhancement in detail.
Explain how the new feature would work and how it would address the problem or improve the Baklava.
- type: textarea
id: alternatives-description
attributes:
label: Alternatives considered
description: |
If you have considered any alternative approaches or solutions, please describe them here.
Explain why the proposed solution is preferred over the alternatives.
- type: textarea
id: additional-context
attributes:
label: Additional technical context
description: |
Provide any additional technical context or considerations that may be relevant to the feature request.
Include code snippets, relevant documentation, or any other information that can help the development team understand and evaluate the request better.
58 changes: 0 additions & 58 deletions .github/ISSUE_TEMPLATE/new-component-definition.md

This file was deleted.

57 changes: 57 additions & 0 deletions .github/ISSUE_TEMPLATE/new-component-definition.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
name: New Component Definition
description: Use this template to define implementation
title: "[Component]: <Name of the component>"
labels: baklava-ds, enhancement
body:
- type: input
id: figma
attributes:
label: Figma Design Document
- type: textarea
id: implementation
attributes:
label: General Usage Example
placeholder: |
```html
<bl-button>Example</bl-button>
```
- type: textarea
id: rules
attributes:
label: Rules
description: Put some rules about how this component should behave and be implemented
placeholder: |
* Rule 1
* Rule 2
- type: textarea
id: attributes
attributes:
label: Attributes
value: |
| Attribute | Description | Default Value |
| --------------- | --------------- | --------------- |
| attr (`string`) | attr desc | - |
- type: textarea
id: slots
attributes:
label: Slots
value: |
| Name | Description | Default Content |
| --------------- | --------------- | --------------- |
| `default` slot | What to put | - |
- type: textarea
id: events
attributes:
label: Events
value: |
| Event | Description |
| --------------- | --------------- |
| `bl-{event-name}` | Event description |
- type: textarea
id: css
attributes:
label: CSS Custom Properties
value: |
| Property | Description | Default Value |
| --------------- | --------------- | --------------- |
| `--bl-name` | Property desc | - |
8 changes: 8 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<Provide a detailed explanation of the changes, why they were necessary, and their benefits or impact>
<Explain the problem you are fixing or the feature you are adding>

## Checklist
- [ ] I have added test cases for this feature
- [ ] I have updated the documentation (if necessary)

<Specify the issues this PR closes, by using closing words like `Closing #[number]`, `Fixes #[number]`>
11 changes: 3 additions & 8 deletions .github/workflows/publish-chromatic.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,15 @@
name: Publish Chromatic

on:
workflow_run:
workflows: ["Verify and Preview", "Verify and Release Beta"]
types:
- completed
workflow_call:

jobs:
publish:
runs-on: ubuntu-latest
if: github.event.workflow_run.conclusion == 'success'
if: github.repository == 'Trendyol/baklava'
steps:
- uses: actions/checkout@v3
with:
repository: ${{ github.event.workflow_run.head_repository.full_name }}
ref: ${{ github.event.workflow_run.head_branch }}
fetch-depth: 0
- name: Set Node env
uses: actions/setup-node@v3
Expand All @@ -28,4 +23,4 @@ jobs:
- name: Publish to Chromatic
uses: chromaui/action@v1
with:
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
projectToken: b94aebe774cc
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: 'Verify and Preview'
on:
pull_request:
branches:
- next
- main

permissions:
pull-requests: read
Expand Down
17 changes: 17 additions & 0 deletions .github/workflows/pull-request-next.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: 'Verify and Preview'

on:
pull_request:
branches:
- next

permissions:
pull-requests: read

jobs:
verify:
uses: trendyol/baklava/.github/workflows/verify.yml@next
secrets: inherit
chromatic:
uses: trendyol/baklava/.github/workflows/publish-chromatic.yml@next
needs: verify
2 changes: 1 addition & 1 deletion .github/workflows/sonar-qube-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
ref: ${{ github.event.workflow_run.head_branch }}
fetch-depth: 0
- name: 'Download artifact'
uses: actions/[email protected].0
uses: actions/[email protected].1
with:
script: |
var artifacts = await github.actions.listWorkflowRunArtifacts({
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/verify-and-release-beta.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ jobs:
uses: trendyol/baklava/.github/workflows/release.yml@next
needs: verify
secrets: inherit
chromatic:
uses: trendyol/baklava/.github/workflows/publish-chromatic.yml@next
needs: verify
12 changes: 1 addition & 11 deletions .storybook/preview-body.html
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
<style>
/* .sb-main-centered #root-inner {
width: 1000px;
height: 400px;
display: flex;
justify-content: center;
align-items: center;
}
.sb-main-fullscreen #root-inner {
height: 600px;
} */
.stacked-form {
display: flex;
flex-direction: column;
Expand All @@ -21,7 +11,7 @@
}

.sbdocs * {
font-family: RubikVariable, sans-serif;
font-family: "Rubik Variable", sans-serif;
}

.sbdocs > bl-alert {
Expand Down
8 changes: 8 additions & 0 deletions .storybook/preview-head.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,12 @@
code {
font-size: 12px;
}

bl-dialog {
font: var(--bl-font-body-text-2)
}

.limited-width {
max-width: 300px;
}
</style>
Loading

0 comments on commit 5cbd553

Please sign in to comment.