Add subtract remove icons moved to QuantityIcons

Trendyol · Oct 17, 2024 · e2f810a · e2f810a
1 parent e8123b7
commit e2f810a
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/libraries/quantity-picker-compose/README.md b/libraries/quantity-picker-compose/README.md
@@ -28,7 +28,6 @@ dependencies {
 
 You can add **QuantityPicker** wherever you want with your modifier
 
-
 | Attribute           | Type                    | Description                                                  |
 | ------------------- | ----------------------- | ------------------------------------------------------------ |
 | modifier            | Modifier                | Compose modifier for QuantityPicker                          |
@@ -87,6 +86,10 @@ QuantityPicker(
 )
 ```
 
+# Repository From
+
+[https://github.com/selimtoksal/QuantityPicker](https://github.com/selimtoksal/QuantityPicker)
+
 # Contributors
 
 This library is maintained mainly by Trendyol Android Team members but also other Android lovers contributes.
@@ -98,3 +101,4 @@ Copyright 2023 Trendyol.com    Licensed under the Apache License, Version 2.0 (t
    http://www.apache.org/licenses/LICENSE-2.0  
 Unless required by applicable law or agreed to in writing, software    distributed under the License is distributed on an "AS IS" BASIS,    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.    See the License for the specific language governing permissions and    limitations under the License.
 ```
+
diff --git a/...y-picker-compose/src/main/java/com/trendyol/uicomponents/quantitypicker/QuantityPicker.kt b/...y-picker-compose/src/main/java/com/trendyol/uicomponents/quantitypicker/QuantityPicker.kt
@@ -1,6 +1,7 @@
 package com.trendyol.uicomponents.quantitypicker
 
 import androidx.compose.animation.AnimatedVisibility
+import androidx.compose.animation.animateContentSize
 import androidx.compose.foundation.background
 import androidx.compose.foundation.border
 import androidx.compose.foundation.layout.Column
@@ -133,11 +134,12 @@ internal fun HorizontalQuantityPicker(
             .background(
                 color = quantityShape.backgroundColor,
                 shape = quantityShape.shape
-            ),
+            )
+            .animateContentSize(),
         verticalAlignment = Alignment.CenterVertically
     ) {
 
-        AnimatedVisibility(visible = quantityData.currentQuantity > 0 || showLoading) {
+        if (quantityData.currentQuantity > 0 || showLoading) {
             Row(verticalAlignment = Alignment.CenterVertically) {
                 QuantitySubtractIcon(
                     icons = icons,

diff --git a/...ity-picker-compose/src/main/java/com/trendyol/uicomponents/quantitypicker/QuantityText.kt b/...ity-picker-compose/src/main/java/com/trendyol/uicomponents/quantitypicker/QuantityText.kt
@@ -2,6 +2,7 @@ package com.trendyol.uicomponents.quantitypicker
 
 import androidx.compose.animation.Crossfade
 import androidx.compose.foundation.background
+import androidx.compose.foundation.clickable
 import androidx.compose.foundation.layout.size
 import androidx.compose.material.CircularProgressIndicator
 import androidx.compose.material.Text
@@ -59,6 +60,7 @@ internal fun QuantityText(
                 text = text,
                 style = textStyle,
                 modifier = Modifier
+                    .clickable(enabled = false) {}
                     .background(
                         shape.backgroundColor,
                         shape.shape