remove unnecessary setters for add icon and add icon enable

Trendyol · Feb 1, 2022 · 314ccef · 314ccef
1 parent 540a0e8
commit 314ccef
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 31 deletions.
diff --git a/buildSrc/src/main/kotlin/ComponentVersions.kt b/buildSrc/src/main/kotlin/ComponentVersions.kt
@@ -7,7 +7,7 @@ object ComponentVersions {
     const val phoneNumberVersion = "1.0.2"
     const val dialogsVersion = "1.2.8"
     const val cardInputViewVersion = "1.1.3"
-    const val quantityPickerViewVersion = "1.2.7"
+    const val quantityPickerViewVersion = "1.2.8"
     const val timelineViewVersion = "1.0.0"
     const val touchDelegatorVersion = "1.0.0"
     const val fitOptionMessageView = "1.0.0"

diff --git a/libraries/quantity-picker-view/README.md b/libraries/quantity-picker-view/README.md
@@ -64,9 +64,7 @@ To set programmatically, you can call `QuantityPickerView.setQuantityPickerViewS
 | setQuantity | quantity: Int | To set quantity immediately. |
 | setMaxQuantity | maxQuantity: Int | To set maxQuantity immediately. |
 | setMinQuantity | minQuantity: Int | To set minQuantity immediately. |
-| setAddIconDrawable | icon: Drawable | To set addIconDrawable immediately. |
 | setBackgroundImageDrawable | background: Drawable | To set backgroundImageDrawable immediately. |
-| setAddButtonEnabled | enable: Boolean | To set enable to addButton immediately |
 | stopLoading |  | To stop current loading.|
 | reset |  | To stop loading and set currentQuantity to 0. |
 | incrementQuantityBy | quantity | increments current total quantity by quantity parameter

diff --git a/...ker-view/src/main/java/com/trendyol/uicomponents/quantitypickerview/QuantityPickerView.kt b/...ker-view/src/main/java/com/trendyol/uicomponents/quantitypickerview/QuantityPickerView.kt
@@ -103,15 +103,13 @@ class QuantityPickerView : ConstraintLayout {
             imageAdd.setOnClickListener {
                 if (viewState?.isLoading() == true) return@setOnClickListener
 
-                if (viewState?.addButtonEnabled == true) {
-                    setQuantityPickerViewState(
-                        if (onAddClicked?.invoke(viewState?.currentQuantity ?: 0) == true) {
-                            viewState?.getWithLoading()
-                        } else {
-                            viewState?.getWithAddValue()
-                        }
-                    )
-                }
+                setQuantityPickerViewState(
+                    if (onAddClicked?.invoke(viewState?.currentQuantity ?: 0) == true) {
+                        viewState?.getWithLoading()
+                    } else {
+                        viewState?.getWithAddValue()
+                    }
+                )
             }
         }
 
@@ -169,16 +167,8 @@ class QuantityPickerView : ConstraintLayout {
     fun setMinQuantity(minQuantity: Int) =
         setQuantityPickerViewState(binding.viewState?.getWithMinQuantity(minQuantity))
 
-    fun setAddIconDrawable(icon: Drawable) {
-        setQuantityPickerViewState(binding.viewState?.getIconAddDrawable(icon))
-    }
-
     fun setBackgroundImageDrawable(background: Drawable){
-        setQuantityPickerViewState(binding.viewState?.getBackgroundDrawable(background))
-    }
-
-    fun setAddButtonEnabled(enable: Boolean) {
-        setQuantityPickerViewState(binding.viewState?.getAddButtonEnabled(enable))
+        setQuantityPickerViewState(binding.viewState?.getWithBackgroundDrawable(background))
     }
 
     fun stopLoading() = setQuantityPickerViewState(binding.viewState?.stopLoading())

diff --git a/...iew/src/main/java/com/trendyol/uicomponents/quantitypickerview/QuantityPickerViewState.kt b/...iew/src/main/java/com/trendyol/uicomponents/quantitypickerview/QuantityPickerViewState.kt
@@ -13,7 +13,6 @@ data class QuantityPickerViewState(
     @ColorInt private val quantityTextColor: Int,
     private val quantityTextSize: Int,
     private val quantityTextStyle: Int = 0,
-    val addButtonEnabled: Boolean = true,
     val currentQuantity: Int = 0,
     val backgroundDrawable: Drawable,
     @ColorInt val progressTintColor: Int,
@@ -159,18 +158,10 @@ data class QuantityPickerViewState(
         return copy(minQuantity = minQuantity, showLoading = false)
     }
 
-    internal fun getIconAddDrawable(icon: Drawable): QuantityPickerViewState {
-        return copy(addIconDrawable = icon)
-    }
-
-    internal fun getBackgroundDrawable(background: Drawable): QuantityPickerViewState {
+    internal fun getWithBackgroundDrawable(background: Drawable): QuantityPickerViewState {
         return copy(backgroundDrawable = background)
     }
 
-    internal fun getAddButtonEnabled(enable: Boolean): QuantityPickerViewState {
-        return copy(addButtonEnabled = enable)
-    }
-
     internal fun stopLoading(): QuantityPickerViewState =
         copy(showLoading = false, expansionState = expansionState.expand())