Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some additional manual concords #360

Merged
merged 6 commits into from
Nov 4, 2024
Merged

Added some additional manual concords #360

merged 6 commits into from
Nov 4, 2024

Conversation

gaurav
Copy link
Collaborator

@gaurav gaurav commented Oct 16, 2024

Some additional manual concords for Disease/Phenotype cliques and DrugChemical conflation.

@gaurav gaurav mentioned this pull request Oct 21, 2024
gaurav and others added 2 commits October 21, 2024 17:06
This is "Technetium Tc 99m Aggregated Albumin".
Base automatically changed from babel-1.8 to master November 2, 2024 18:52
@gaurav gaurav requested a review from cbizon November 2, 2024 19:53
@gaurav gaurav marked this pull request as ready for review November 2, 2024 19:53
Copy link
Contributor

@cbizon cbizon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good. I'm slightly uneasy about including the MONDO ones. Can we make a PR or issue on MONDO to add these to their exact matches?

@gaurav
Copy link
Collaborator Author

gaurav commented Nov 4, 2024

These look good. I'm slightly uneasy about including the MONDO ones. Can we make a PR or issue on MONDO to add these to their exact matches?

Good point. I dug into this a bit deeper and discovered that these xrefs are actually present in MONDO and in our intermediate files -- we're just separating the MONDO identifier into its own clique for some reason, which adding it to the manual concord in this PR does override. I'll merge this for now, but then I'll try to figure that out in #369

@gaurav gaurav merged commit 242c179 into master Nov 4, 2024
@gaurav gaurav deleted the add-manual-concords branch November 4, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants