Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile: move asset gems to 'default' (rm 'assets' section) #3066

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JedMeister
Copy link

Hi @ZeiP 👋 😎

I'm no RoR expert, but this seems like the "right" fix for #3065?! My rationale is here.

If you don't like this approach please share your preferred path and I'll have another stab. I'd also be really interested in your rationale.

Update Gemfile:


FYI I haven't explicitly tested as per CONTRIBUTING.md.

I have tested in a chroot during TKL Tracks app v18.1 update dev. I'll also do a final pre-release smoke test. Others have also confirmed a similar "fix" in #3065. Hopefully that's good enough?

@JedMeister
Copy link
Author

JedMeister commented Oct 9, 2024

Looking at the test failure, it seems to be failing because GH dropped support for docker compose v1. As noted there, the primary change required is docker-compose -> docker compose but there may be other considerations? When I get a chance I'll have a closer look but I don't have docker installed anywhere handy (only podman).

@ZeiP
Copy link
Member

ZeiP commented Oct 23, 2024

I finally got around to fixing the tests, they're working again 📈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Precompiling assets fails, could not find bootstrap-sprockets
2 participants