Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to record redact() SDK requests #10

Merged
merged 6 commits into from
Dec 3, 2024
Merged

Add option to record redact() SDK requests #10

merged 6 commits into from
Dec 3, 2024
+83 −4

Conversation

akamor
Copy link
Contributor

@akamor akamor commented Dec 2, 2024

No description provided.

JaniceManwiller
JaniceManwiller reviewed Dec 2, 2024
View reviewed changes
docs/source/redact/redacting_text.rst Outdated Show resolved Hide resolved
docs/source/redact/redacting_text.rst Outdated Show resolved Hide resolved
docs/source/redact/redacting_text.rst Outdated Show resolved Hide resolved
tonic_textual/classes/record_api_request_options.py Outdated Show resolved Hide resolved
tonic_textual/classes/record_api_request_options.py Outdated Show resolved Hide resolved
tonic_textual/classes/record_api_request_options.py Outdated Show resolved Hide resolved
tonic_textual/classes/record_api_request_options.py Outdated Show resolved Hide resolved
tonic_textual/redact_api.py Outdated Show resolved Hide resolved
tonic_textual/redact_api.py Outdated Show resolved Hide resolved
@akamor @JaniceManwiller
Apply suggestions from code review
a1743d6 
Co-authored-by: Janice Manwiller <[email protected]>
@joeferraratonic
Copy link
Contributor

The redact_bulk function does not record the API requests neither with the current code nor with the suggested changes. Something is not working correctly in the /api/redact/bulk endpoint.

@joeferraratonic
Copy link
Contributor

The redact_bulk function does not record the API requests neither with the current code nor with the suggested changes. Something is not working correctly in the /api/redact/bulk endpoint.

I changed the suggested changes to just take the record logic out of the redact_bulk function so that it would only exist for the redact function.

joeferraratonic
joeferraratonic requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@joeferraratonic joeferraratonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few suggested changes to fix type hints so that users do not inadvertently set a parameter to None that they cannot set to None.

The one substantive comment is that the parameter in the redact_bulk function for recording the API request into the Textual UI does not do anything if set to True.

joeferraratonic
joeferraratonic previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@joeferraratonic joeferraratonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akamor akamor enabled auto-merge December 3, 2024 18:21
joeferraratonic
joeferraratonic approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@joeferraratonic joeferraratonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akamor akamor merged commit c8621be into main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaniceManwiller JaniceManwiller JaniceManwiller left review comments

@joeferraratonic joeferraratonic joeferraratonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akamor @joeferraratonic @JaniceManwiller