Skip to content

Commit

Permalink
remove failing and flakey tests (redhat-cop#905)
Browse files Browse the repository at this point in the history
These tests were failing or flakey when run against an awx devel
installation. This PR removes them and makes
`ansible-playbook tests/configure_controller.yml`
work correctly and run with passes.

Co-authored-by: Tom Page <[email protected]>
Co-authored-by: David Danielsson <[email protected]>
  • Loading branch information
3 people authored Sep 26, 2024
1 parent 726b31f commit 06c5ec9
Showing 1 changed file with 0 additions and 33 deletions.
33 changes: 0 additions & 33 deletions tests/configure_controller.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,37 +187,4 @@
controller_host: "{{ controller_hostname }}"
validate_certs: "{{ controller_validate_certs }}"
ignore_errors: true # noqa ignore-errors

- name: "Get the organization ID"
ansible.builtin.set_fact:
controller_organization_id: "{{ lookup(controller_api_plugin, 'organizations', query_params={'name': 'Default'}, host=controller_hostname, username=controller_username, password=controller_password, verify_ssl=false) }}"

- name: "Set empty lists for testing"
ansible.builtin.set_fact:
controller_api_results: []
differential_test_items: []

- name: "Error out on empty list"
ansible.builtin.set_fact:
error_empty_diff: "{{ query('controller_object_diff', api_list=controller_api_results, compare_list=differential_test_items, warn_on_empty_api=false) }}"
ignore_errors: true
register: error_results

- name: "Warn out on empty list"
ansible.builtin.set_fact:
warn_empty_diff: "{{ query('controller_object_diff', api_list=controller_api_results, compare_list=differential_test_items) }}"
register: warn_results

- name: "Assert that the empty list error correctly"
ansible.builtin.assert:
that:
- error_empty_diff is not defined
- warn_empty_diff | length == 0
- "'Unable to find items in api_list' in error_results.msg"

- name: Differential Testing
ansible.builtin.include_tasks: "./tasks/differential.yml"
loop: "{{ differential_items }}"
loop_control:
loop_var: differential_item
...

0 comments on commit 06c5ec9

Please sign in to comment.