Fixing broken tests when addressing account filters bug.

TomorrowIdeas · Aug 20, 2020 · f2571f7 · f2571f7
1 parent d12c12a
commit f2571f7
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 12 deletions.
diff --git a/src/Entities/AccountFilters.php b/src/Entities/AccountFilters.php
@@ -7,7 +7,7 @@ class AccountFilters
 	/**
 	 * Filters to be applied.
 	 *
-	 * @var array<string,array<string>>
+	 * @var array<string,array<string,array<string>>>
 	 */
 	protected $filters = [];
 
@@ -128,7 +128,7 @@ public function setOtherFilters(array $subtypes): void
 	/**
 	 * Get all filters as array.
 	 *
-	 * @return array<string,array<string>>
+	 * @return array<string,array<string,array<string>>>
 	 */
 	public function toArray(): array
 	{

diff --git a/tests/AccountFiltersEntityTest.php b/tests/AccountFiltersEntityTest.php
@@ -17,7 +17,11 @@ public function test_constructor_sets_filters(): void
 		$accountFilters = new AccountFilters($filters);
 
 		$this->assertEquals(
-			$filters,
+			[
+				"depository" => [
+					"account_subtypes" => ["auth", "identity"]
+				]
+			],
 			$accountFilters->toArray()
 		);
 	}
@@ -45,7 +49,7 @@ public function test_set_depository_filters(): void
 		$this->assertEquals(
 			[
 				"depository" => [
-					"auth", "transactions", "identity", "income", "assets"
+					"account_subtypes" => ["auth", "transactions", "identity", "income", "assets"]
 				]
 			],
 			$accountFilters->toArray()
@@ -60,7 +64,7 @@ public function test_set_credit_filters(): void
 		$this->assertEquals(
 			[
 				"credit" => [
-					"transactions", "identity", "liabilities"
+					"account_subtypes" => ["transactions", "identity", "liabilities"]
 				]
 			],
 			$accountFilters->toArray()
@@ -75,7 +79,7 @@ public function test_set_investment_filters(): void
 		$this->assertEquals(
 			[
 				"investment" => [
-					"investments"
+					"account_subtypes" => ["investments"]
 				]
 			],
 			$accountFilters->toArray()
@@ -90,7 +94,7 @@ public function test_set_loan_filters(): void
 		$this->assertEquals(
 			[
 				"loan" => [
-					"transactions", "liabilities"
+					"account_subtypes" => ["transactions", "liabilities"]
 				]
 			],
 			$accountFilters->toArray()
@@ -105,7 +109,7 @@ public function test_set_other_filters(): void
 		$this->assertEquals(
 			[
 				"other" => [
-					"auth", "transactions", "identity", "assets"
+					"account_subtypes" => ["auth", "transactions", "identity", "assets"]
 				]
 			],
 			$accountFilters->toArray()

diff --git a/tests/CreateLinkTokenTest.php b/tests/CreateLinkTokenTest.php
@@ -78,9 +78,15 @@ public function test_account_filters(): void
 		);
 
 		$this->assertEquals(
-			(object) [
-				"depository" => ["auth", "transactions"]
-			],
+			\json_decode(
+				\json_encode(
+					[
+						"depository" => [
+							"account_subtypes" => ["auth", "transactions"]
+						]
+					]
+				)
+			),
 			$response->params->account_filters
 		);
 	}
@@ -117,7 +123,10 @@ public function test_redirect_uri(): void
 			"http://redirect.uri"
 		);
 
-		$this->assertEquals("http://redirect.url", $response->params->redirect_uri);
+		$this->assertEquals(
+			"http://redirect.uri",
+			$response->params->redirect_uri
+		);
 	}
 
 	public function test_android_package_name(): void