Skip to content

Commit

Permalink
API/TST: Call __finalize__ in more places
Browse files Browse the repository at this point in the history
Progress towards pandas-dev#28283. This
adds tests that ensures `NDFrame.__finalize__` is called in more places.
Thus far I've added tests for anything that meets the following rule:

> Pandas calls `NDFrame.__finalize__` on any NDFrame method that returns
> another NDFrame.

I think that given the generality of `__finalize__`, making any kind of
list of which methods should call it is going to be somewhat arbitrary.
That rule errs on the side of calling it too often, which I think is my
preference.
  • Loading branch information
TomAugspurger committed Apr 7, 2020
1 parent abf587c commit 6fb29d7
Showing 1 changed file with 654 additions and 0 deletions.
Loading

0 comments on commit 6fb29d7

Please sign in to comment.