Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing px unit to width and height attributes #506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing px unit to width and height attributes #506

wants to merge 1 commit into from

Conversation

astrotuna201
Copy link

PR fixes missing "px" units to width and height attribute, that resulted in attribute being dropped as invalid by browsers.

@carson-katri carson-katri added the bug Something isn't working label Jul 18, 2022
@MaxDesiatov MaxDesiatov requested a review from carson-katri July 29, 2022 20:20
@MaxDesiatov MaxDesiatov changed the title add missing length unit to width and height attributes Add missing px unit to width and height attributes Jul 29, 2022
MaxDesiatov
MaxDesiatov requested changes Jul 30, 2022
View reviewed changes
Copy link
Collaborator

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to add a test (possibly a snapshot test if you find that more appropriate) to prevent regressions in the future? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov requested changes

@carson-katri carson-katri Awaiting requested review from carson-katri

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astrotuna201 @MaxDesiatov @carson-katri