-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge with upstream #10
base: master
Are you sure you want to change the base?
Conversation
1a165ac
to
c31495f
Compare
c31495f
to
c8704f4
Compare
Dear JFreegman,
|
@@ -1,15 +1,17 @@ | |||
.{ | |||
.name = "zig-toxcore-c", | |||
.name = "c-toxcore-zig", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the rename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, the original repository name at nodecum is c-toxcore-zig...
Should I rename the original one? This could mess things up or?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean how would github behave if I rename nodecum/c-toxcore-zig which is the origin of the fork of TokTok/zig-toxcore-c.
Just out of curiosity, why don't the bindings simply link libtoxcore as a system lib? |
Linking to libtoxcore as a system lib would be possible for sure. However then you would have to install (and maybe build) it yourself. Maybe we could have both options, to use a installed system libtoxcore or a static zig build libtoxcore with a tight coupling to the used revision and building of the lib. |
Upstream is currently staying up-to-date with Zig master instead of a major release. This PR will fix the build for Zig master (2024-11-14), but I think we should stop updating the API until the next major release, and then stick with that.
This change is