Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use Qt RCC format version 1 to avoid storing mtime. #892

Merged
merged 1 commit into from
Nov 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions third_party/qt/build_defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,11 @@ def _qt_rcc_impl(ctx):
arguments = [src.path for src in srcs] + [
"--name",
ctx.attr.name,
# Drop the file modification time of source files from generated files
# to help with reproducible builds. We do not use QFileInfo.lastModified
# so this has no unwanted side effects.
"-format-version",
"1",
"--compress",
"9",
"--threshold",
Expand Down
Loading