Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Actually handle all the cases of versions being available or not. #84

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: Actually handle all the cases of versions being available or not. #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions bin/check_release
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,23 +146,25 @@ def main(prog: str, args: List[str]) -> None:
print(f"PR Milestone release: {pr_release}")
print(f"Local release: {local_release} ({local_origin})")

if gh_release is None:
# Default to the milestone version if we can't read the draft release
# version. This happens when we call the workflow from a pull_request
# event as opposed to a pull_request_target event.
gh_release = ms_release

if local_required and gh_release != local_release:
if local_required and gh_release and gh_release != local_release:
print(f"\nFAIL: GitHub draft release {gh_release} does not match "
f"{local_origin} {local_release}")
sys.exit(1)
if pr_release and ms_release != pr_release:
if local_required and ms_release != local_release:
print(f"\nFAIL: Next GitHub Milestone release {ms_release} does not "
f"match PR milestone {pr_release}")
f"match {local_origin} {local_release}")
sys.exit(1)
if pr_release and pr_release != local_release:
print(f"\nFAIL: PR milestone {pr_release} does not match "
f"{local_origin} {local_release}")
sys.exit(1)
if pr_release and gh_release != pr_release:
if gh_release and gh_release != ms_release:
print(f"\nFAIL: GitHub draft release {gh_release} does not match "
f"PR milestone {pr_release}")
f"next GitHub Milestone release {ms_release}")
sys.exit(1)
if pr_release and pr_release != ms_release:
print(f"\nFAIL: PR milestone {pr_release} does not match "
f"next GitHub Milestone release {ms_release}")
sys.exit(1)

print(f"\nPASS: Upcoming release version is {gh_release}")
Expand Down
Loading