Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getBrowserInfo() errors in Chrome/Chromium #18

Closed
tdulcet opened this issue Jun 1, 2021 · 2 comments · Fixed by #19
Closed

getBrowserInfo() errors in Chrome/Chromium #18

tdulcet opened this issue Jun 1, 2021 · 2 comments · Fixed by #19
Assignees

Comments

@tdulcet
Copy link

tdulcet commented Jun 1, 2021

Continuation of #11 and #12. See #12 (comment):

As expected, I do get some errors in the console, but they are probably better fixed with #11:
image

I believe we will need to implement something similar to this: rugk/unicodify#23 (comment).

@rugk rugk self-assigned this Jun 1, 2021
@rugk
Copy link
Member

rugk commented Jun 1, 2021

Okay, so IMHO the polyfill should handle this.

WOuld you mind to create an issue at https://github.com/mozilla/webextension-polyfill/?
Ah okay no, it does not do this: mozilla/webextension-polyfill#116

@rugk
Copy link
Member

rugk commented Jun 1, 2021

Okay, fixed it.

I did some crazy thing and decided to use the (long-upon a time written and nearly forgotten) tests for that…
#19

I know the tests are ugly and running them is a pain and I would not do so nowadays likely, but uff… let's ignore that.

@rugk rugk changed the title Errors in Chrome/Chromium getBrowserInof() errors in Chrome/Chromium Jun 1, 2021
@rugk rugk changed the title getBrowserInof() errors in Chrome/Chromium getBrowserInfo() errors in Chrome/Chromium Jun 1, 2021
@rugk rugk closed this as completed in #19 Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants