Minor improvements to conn-trac

Signed-off-by: Richard T Bonhomme <[email protected]>

easytls-client-connect.sh

@@ -179,15 +179,16 @@ conn_trac_connect ()
 		update_status "TLS-Crypt-V2 key added to conn-trac"
 	fi
 	unset file_data
-}
+} # => conn_trac_connect ()
 
 # Update connection tacking - disconnect
 conn_trac_disconnect ()
 {
 	[ $ENABLE_CONN_TRAC ] || return 0
 	"${EASYTLS_SED}" -i "/^${tlskey_serial}\$/d" "${EASYTLS_CONN_TRAC}"
 	update_status "TLS-Crypt-V2 key removed from conn-trac"
-}
+	[ -s "${EASYTLS_CONN_TRAC}" ] || "${EASYTLS_RM}" -f "${EASYTLS_CONN_TRAC}"
+} # => conn_trac_disconnect ()
 
 # Initialise
 init ()
@@ -375,10 +376,12 @@ if [ -f "${TCV2KEY_SERIAL_FILE}" ]
 then
 	tlskey_serial="$("${EASYTLS_CAT}" "${TCV2KEY_SERIAL_FILE}")" || \
 		die "Failed to set tlskey_serial"
+	update_status "Found tlskey-serial"
 	"${EASYTLS_RM}" "${TCV2KEY_SERIAL_FILE}"
 else
 	# Not using TLS-Crypt-V2 key
 	tlskey_serial="00000000000000000000000000000000"
+	update_status "NO TLSKEY SERIAL"
 fi
 
 # easytls client metadata file

easytls-client-disconnect.sh

@@ -167,7 +167,8 @@ conn_trac_disconnect ()
 	[ $ENABLE_CONN_TRAC ] || return 0
 	"${EASYTLS_SED}" -i "/^${tlskey_serial}\$/d" "${EASYTLS_CONN_TRAC}"
 	update_status "TLS-Crypt-V2 key removed from conn-trac"
-}
+	[ -s "${EASYTLS_CONN_TRAC}" ] || "${EASYTLS_RM}" -f "${EASYTLS_CONN_TRAC}"
+} # => conn_trac_disconnect ()
 
 # Initialise
 init ()

easytls-cryptv2-verify.sh

@@ -442,7 +442,7 @@ conn_trac_connect ()
 	[ $ENABLE_CONN_TRAC ] || return 0
 	[ -f "${EASYTLS_CONN_TRAC}" ] && \
 		file_data="$("${EASYTLS_CAT}" "${EASYTLS_CONN_TRAC}")"
-	if "${EASYTLS_GREP}" "^${tlskey_serial}$" "${EASYTLS_CONN_TRAC}"
+	if "${EASYTLS_GREP}" -q "^${tlskey_serial}$" "${EASYTLS_CONN_TRAC}"
 	then
 		# Already connected don't add another
 		update_status "TLS-key serial is already registered in conn-trac"
@@ -454,7 +454,7 @@ conn_trac_connect ()
 		update_status "TLS-Crypt-V2 key added to conn-trac"
 	fi
 	unset file_data
-}
+} # => conn_trac_connect ()
 
 # Initialise
 init ()
@@ -1018,9 +1018,10 @@ else
 		die "Failed to create client_metadata_file" 89
 	update_status "Created client_metadata_file"
 
-	# Ugly generic_metadata_file hack
+	# Unfortunate generic_metadata_file hack
 	if [ -f "${generic_metadata_file}" ]
 	then
+		#die "Why This File - generic_metadata_file"
 		"${EASYTLS_RM}" -f "${generic_metadata_file}"
 		update_status "Deleted generic_metadata_file"
 		"${EASYTLS_CP}" "${OPENVPN_METADATA_FILE}" "${generic_metadata_file}" || \

easytls-verify.sh

@@ -189,7 +189,8 @@ conn_trac_disconnect ()
 	[ $ENABLE_CONN_TRAC ] || return 0
 	"${EASYTLS_SED}" -i "/^${tlskey_serial}\$/d" "${EASYTLS_CONN_TRAC}"
 	update_status "TLS-Crypt-V2 key removed from conn-trac"
-}
+	[ -s "${EASYTLS_CONN_TRAC}" ] || "${EASYTLS_RM}" -f "${EASYTLS_CONN_TRAC}"
+} # => conn_trac_disconnect ()
 
 # Create stage-1 file
 create_stage1_file ()