Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add h264 encoder support #1869

Closed
wants to merge 1 commit into from
Closed

Conversation

Icy-Locust
Copy link

Just curious why we don't have H.264 encoder support.
This PR contains ffmpeg libav implementation just for Linux.
It is a bare encoder with low efficiency, but better than nothing.
Any comments are welcome!

@Icy-Locust Icy-Locust marked this pull request as ready for review November 13, 2024 07:40
@Icy-Locust Icy-Locust marked this pull request as draft November 13, 2024 07:40
@CendioOssman
Copy link
Member

Thanks for your contribution!

The reason we don't have it is mainly because it is unclear if it's efficient. It needs to provide an advantage over the current encoders for us to add it, much less give it priority.

What kind of performance have you seen in your tests?

@Icy-Locust
Copy link
Author

As this article and this issue suggest, it's currently reasonable not to implement H.264 encoding.
Frames sent by this encoder are all I-frames, which means that we don't take full advantage of H.264 codec.
We need to redesign the way encoder processes the buffer, and add bit rate control algorithm.
Close this PR, and any ideas are welcome!

@Icy-Locust Icy-Locust closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants