Move recent server to top of history

It's easier for the user if the most recently used entries are at the top.
TigerVNC · Sep 6, 2024 · af29133 · af29133
1 parent a19219e
commit af29133
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/vncviewer/ServerDialog.cxx b/vncviewer/ServerDialog.cxx
@@ -292,13 +292,12 @@ void ServerDialog::handleConnect(Fl_Widget* /*widget*/, void *data)
              e.str());
   }
 
+  // avoid duplicates in the history
+  dialog->serverHistory.remove(servername);
+  dialog->serverHistory.insert(dialog->serverHistory.begin(), servername);
+
   try {
-    list<string>::iterator elem = std::find(dialog->serverHistory.begin(), dialog->serverHistory.end(), servername);
-    // avoid duplicates in the history
-    if(dialog->serverHistory.end() == elem) {
-      dialog->serverHistory.insert(dialog->serverHistory.begin(), servername);
-      dialog->saveServerHistory();
-    }
+    dialog->saveServerHistory();
   } catch (Exception& e) {
     vlog.error("%s", e.str());
     fl_alert(_("Unable to save the server history:\n\n%s"),