Skip to content

Commit

Permalink
[nc] iterate on publish release notes
Browse files Browse the repository at this point in the history
Signed-off-by: Nic Cheneweth <[email protected]>
  • Loading branch information
ncheneweth committed Oct 21, 2024
1 parent 197c142 commit d23db18
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 22 deletions.
42 changes: 21 additions & 21 deletions .github/workflows/publish-container.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ on:
description: path to file containing release message body
required: false
type: string
default: ""
default: "release-notes.md"

release-artifacts:
description: path to artifacts to include in release
Expand Down Expand Up @@ -290,26 +290,26 @@ jobs:
registry: ${{ inputs.registry}}
sbom-filename: ${{ inputs.sbom-filename }}

# - name: Publish Release
# if: ${{ inputs.release-notes == 'true' }}
# uses: actions/create-release@v1
# id: create_release
# env:
# GITHUB_TOKEN: ${{ github.token }}
# with:
# draft: false
# prerelease: false
# release_name: ${{ inputs.tag-annotation }}${{ inputs.version-tag }}
# tag_name: ${{ inputs.version-tag }}
# body_path: ${{ inputs.release-body-path }}

# - name: Upload release binaries
# if: ${{ inputs.release-artifacts != 'false' }}
# uses: alexellis/[email protected]
# env:
# GITHUB_TOKEN: ${{ github.token }}
# with:
# asset_paths: ${{ inputs.release-artifacats }}
- name: Publish Release
if: ${{ inputs.release-notes == 'true' }}
uses: actions/create-release@v1
id: create_release
env:
GITHUB_TOKEN: ${{ github.token }}
with:
draft: false
prerelease: false
release_name: ${{ inputs.tag-annotation }}${{ inputs.version-tag }}
tag_name: ${{ inputs.version-tag }}
body_path: ${{ inputs.release-body-path }}

- name: Upload release binaries
if: ${{ inputs.release-artifacts != 'false' }}
uses: alexellis/[email protected]
env:
GITHUB_TOKEN: ${{ github.token }}
with:
asset_paths: ${{ inputs.release-artifacats }}

# - name: publish semantic release version from tag

Check warning on line 314 in .github/workflows/publish-container.yaml

View workflow job for this annotation

GitHub Actions / static code analysis / gha-tools-action static code analysis workflow

314:7 [comments-indentation] comment not indented like content
# if: ${{ inputs.release-notes == 'true' }}
Expand Down
2 changes: 1 addition & 1 deletion snyk-scan/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ runs:
exit 0
fi
- name: upload trivy scan log as saved artifact
- name: upload snyk scan log as saved artifact
if: ${{ inputs.security-scan-nofail == 'true' }}
uses: actions/upload-artifact@v4
with:
Expand Down

0 comments on commit d23db18

Please sign in to comment.