Skip to content

Commit

Permalink
Added comment explaining why a refactor has caused unintentional issu…
Browse files Browse the repository at this point in the history
…es in the past
  • Loading branch information
ThomasRahm committed Jan 3, 2023
1 parent 1724f67 commit 6217ebf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/TreeSupport.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,8 @@ std::vector<TreeSupport::LineInformation> TreeSupport::convertLinesToInternal(Po

// NOTE: The volumes below (on which '.inside(p, true)' is called each time below) are the same each time. The values being calculated here are strictly local as well.
// So they could in theory be pre-calculated here (outside of the loop). However, when I refatored it to be that way, it seemed to cause deadlocks each time for some settings.

// NOTE2: When refactoring ensure that avoidance to buildplate is only requested when support_rest_preference == RestPreference::BUILDPLATE as otherwise it has not been precalculated (causing long delays while it is calculated when requested here).

std::vector<LineInformation> result;
// Also checks if the position is valid, if it is NOT, it deletes that point
for (const auto& line : polylines)
Expand Down

0 comments on commit 6217ebf

Please sign in to comment.