update associations according to dython new syntax

ThomasBury · Jan 31, 2022 · 992c271 · 992c271
1 parent 2210858
commit 992c271
Show file tree

Hide file tree

Showing 4 changed files with 63 additions and 54 deletions.
diff --git a/arfs/featselect.py b/arfs/featselect.py
@@ -25,7 +25,7 @@
 # numpy and pandas for data manipulation
 import pandas as pd
 import numpy as np
-from dython.nominal import compute_associations
+from dython.nominal import associations
 # model used for feature importance, Shapley values are builtin
 import lightgbm as lgb
 from lightgbm import early_stopping
@@ -219,13 +219,16 @@ def plot_associations(df, features=None, size=1200, theil_u=False):
     # nominal features
     nom_features = set(features) - set(con_features)
 
-    assoc_df = compute_associations(df,
-                                    nominal_columns=nom_features,
-                                    mark_columns=True,
-                                    theil_u=theil_u,
-                                    clustering=True,
-                                    bias_correction=True,
-                                    nan_strategy='drop_samples')
+    nom_nom_assoc = 'theil' if theil_u else 'cramer'
+    assoc_df = associations(df,
+                            nominal_columns=nom_features,
+                            mark_columns=True,
+                            num_num_assoc='spearman',
+                            nom_nom_assoc=nom_nom_assoc,
+                            clustering=True,
+                            bias_correction=True,
+                            nan_strategy='drop_samples',
+                            compute_only=True)['corr']
 
     heatmap = hv.HeatMap((assoc_df.columns, assoc_df.index, assoc_df)).redim.range(z=(-1, 1))
 
@@ -743,14 +746,14 @@ def identify_collinear(self, correlation_threshold, encode=False, method='associ
             # nominal features
             nom_features = set(features) - set(con_features)
 
-            self.corr_matrix = compute_associations(self.data,
-                                                    nominal_columns=nom_features,
-                                                    mark_columns=True,
-                                                    num_num_assoc='spearman',
-                                                    nom_nom_assoc='theil',
-                                                    clustering=True,
-                                                    bias_correction=True,
-                                                    nan_strategy='drop_samples')
+            self.corr_matrix = associations(self.data,
+                                            nominal_columns=nom_features,
+                                            mark_columns=True,
+                                            num_num_assoc='spearman',
+                                            nom_nom_assoc='theil',
+                                            clustering=True,
+                                            nan_strategy='drop_samples',
+                                            compute_only=True)['corr']
 
             upper = self.corr_matrix.where(np.triu(np.ones(self.corr_matrix.shape), k=1).astype(np.bool))
             to_drop = [column for column in upper.columns if
@@ -1271,7 +1274,7 @@ def plot_collinear(self, plot_all=False, size=1000):
         panel_layout = pn.Column(
                 pn.pane.Markdown(title_str, align="start"),  # bold
                 pn.pane.Markdown(sub_title_str, align="start"),  # italic
-                heatmap, background='#ebebeb'
+                heatmap, background='#b3b3b3'
         )
 
         return panel_layout

diff --git a/changelog.md b/changelog.md
@@ -1,5 +1,8 @@
 # Changes
 
+## 0.3.1 
+
+ - Update the syntax for computing associations using the latest version of dython
 ## 0.3.0
 
  - Fix the Boruta_py feature counts, now adds up to n_features